Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize NetworkAction objects #11

Closed
phogue opened this issue Nov 22, 2013 · 0 comments
Closed

Standardize NetworkAction objects #11

phogue opened this issue Nov 22, 2013 · 0 comments
Assignees

Comments

@phogue
Copy link
Owner

phogue commented Nov 22, 2013

Procon.Net.Protocols.Objects.Chat already uses the Then/Now/Scope attributes of NetworkAction but Procon.Net.Protocols.Objects.Kill still uses a very specialized object.

Moving Kick/Kill and other NetworkAction objects over to use these three NetworkActionData fields (or creating new fields like "Instigator" and some clever antonym of instigator that I can't think of right now) will allow for multiple actions to be taken on a single object, so a plugin can list 5 players they want to Move/Kick/Kill and the appropriate action will be taken.

The work's already half done, I've just been lazy.

@ghost ghost assigned phogue Nov 22, 2013
phogue pushed a commit that referenced this issue Nov 22, 2013
phogue pushed a commit that referenced this issue Nov 22, 2013
phogue pushed a commit that referenced this issue Nov 22, 2013
Now favours the content list of strings for reasons
@phogue phogue closed this as completed Nov 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant