Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages should not load in full trust #37

Closed
phogue opened this issue Jan 14, 2014 · 0 comments
Closed

Packages should not load in full trust #37

phogue opened this issue Jan 14, 2014 · 0 comments
Assignees

Comments

@phogue
Copy link
Owner

phogue commented Jan 14, 2014

Protocol assemblies are currently loaded in Procon's instance AppDomain which runs in full trust.

This should be modified to load these assemblies in an AppDomain which only has access to protocol package path and UDP/TCP network access on the port to the game hostname. This will mean adding a new connection will require all existing connections to restart, but the security is worth the inconvenience.

It's a slightly increased level of trust from a plugin, but only because it needs to do more. It's not exactly a plugin, which is why it's handled elsewhere.

@ghost ghost assigned phogue Jan 14, 2014
phogue pushed a commit that referenced this issue Apr 9, 2014
It was originally an attribute of IProtocol, butit makes more sense to
belong to the setup variables for the protocol.
phogue pushed a commit that referenced this issue Apr 9, 2014
This is so the protocol in the appdomain can read the maxmind file
phogue pushed a commit that referenced this issue Apr 9, 2014
@phogue phogue closed this as completed Apr 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant