Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command.ToConfigCommand nulling scope #51

Closed
phogue opened this issue Mar 6, 2014 · 0 comments
Closed

Command.ToConfigCommand nulling scope #51

phogue opened this issue Mar 6, 2014 · 0 comments
Assignees

Comments

@phogue
Copy link
Owner

phogue commented Mar 6, 2014

When saving the config the plugins that are enabled are not being reenabled on load. This is because ToConfigCommand nulls out the scope.

Need a couple unit tests to validate the config can be saved/loaded for the plugin controller correctly.

Investigate why ToConfigCommand is nulling out the scope. I think it's just to make config's look prettier so the scope is not filled with lot's of empty GUID's for no reason.

Perhaps change over so if all GUID's in scope are empty then the scope can be nulled, otherwise the command requires it's scope.

@phogue phogue added bug labels Mar 6, 2014
@phogue phogue self-assigned this Mar 6, 2014
@phogue phogue closed this as completed in a026898 Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant