Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptionException message contains duplicate missing required options. #79

Closed
derekmahar opened this issue May 13, 2015 · 3 comments
Closed

Comments

@derekmahar
Copy link

Please remove the duplicate option names from the "Missing required option(s)" message that OptionException produces when a required option has synonyms.

Example:

OptionException message contains three required options (one for each name):

Missing required option(s) [f/csv-file-name/ff, f/csv-file-name/ff, f/csv-file-name/ff].

Usage: java -jar fatca.jar com.opessoftware.fatca.App [options]

Option (* = required)                    Description                 
---------------------                    -----------                 
-?, -h, --help                           Display usage information.  
* -f, --csv-file-name, --ff <PATH_NAME>  Path name of input CSV file.

Expected behaviour is that OptionException message should contain only one required option that lists all names:

Missing required option(s) [f/csv-file-name/ff].
@pholser
Copy link
Collaborator

pholser commented May 13, 2015

Whoops! Sorry for this oversight. Will correct.

pholser added a commit that referenced this issue May 13, 2015
This occurs in OptionException.multipleOptionString() when handling
options with synonyms.
@pholser
Copy link
Collaborator

pholser commented May 13, 2015

I've corrected this on both the 4.x and master branches.

@derekmahar
Copy link
Author

Thank you! Quick turnaround time! (So do I get my name in the list of contributors? ;-))

@pholser pholser closed this as completed May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants