New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why api changed in a minor version? #29

Open

junaid1460 opened this issue Nov 20, 2023 · 2 comments

junaid1460 commented Nov 20, 2023 •

edited

There's no perf gain or anything here, we should not change things like this

Author

junaid1460 commented Nov 20, 2023

Better api would be PhosphorIcon accepting styles why those can remain function as params.

sevenreup commented Nov 26, 2023

I was also wandering about the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment