Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing icons #31

Closed
mtancoigne opened this issue Apr 9, 2021 · 6 comments
Closed

Drawing icons #31

mtancoigne opened this issue Apr 9, 2021 · 6 comments
Assignees
Labels
icon Request for a new icon

Comments

@mtancoigne
Copy link

Describe the requested icon
It would be nice to have drawing-related icons : I'm building an app where people can trace shapes on a map and I came with these manually drawn icons (screenshot):
The downside of these is:

  • They don't really fit with other phosphor icons
  • They are SVGs, inlined in an img tag thus don't support color variations

Basically, I'd like the following icons:

  • polygon shape
  • multi-line shape

I haven't seen a way to combine icons (e.g.: a ph-map-pin with an upper ph-plus), these variants are welcome:

  • ph-map-pin +
  • ph-circle +
  • polygon +
  • multi-line +

Screenshots
image

Additional context
If you're interested to add these and want a base, the sources are available. (I see there are some more outdated ones from when I wasn't yet using Phosphor :) )

I can also make a PR with an attempt to match your design.

Thanks for the good work, your set is refreshing :)

@mtancoigne mtancoigne added the enhancement New feature or request label Apr 9, 2021
@mtancoigne
Copy link
Author

mtancoigne commented May 7, 2021

Hello! I'm coming back to see if you're interested to add these icons in the set...

@rektdeckard
Copy link
Member

Hey, sorry for the delay. I think we can add some of the design tool icons you're looking for, yes. We'll have to look and see where the case can be made for '+ variants', or if they're a bit too specific to your application.

@minoraxis
Copy link

Thanks for the suggestions @mtancoigne Working on these this weekend. Polygon and multiline should be fun :) Modifiers like "+" can get tricky in terms of readability but will take a look at those as well.

@minoraxis minoraxis assigned minoraxis and unassigned rektdeckard May 29, 2021
@mtancoigne
Copy link
Author

Thanks @minoraxis! Have a good time !

@minoraxis
Copy link

We've added bounding-box, line-segment, line-segments, and polygon in v1.3.1!

@mtancoigne
Copy link
Author

You're awesome ! Thanks !

@rektdeckard rektdeckard added icon Request for a new icon and removed enhancement New feature or request labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icon Request for a new icon
Projects
None yet
Development

No branches or pull requests

3 participants