Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found this issue when trying to build my library #40

Closed
sagoAguilar opened this issue Mar 8, 2023 · 3 comments
Closed

Found this issue when trying to build my library #40

sagoAguilar opened this issue Mar 8, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@sagoAguilar
Copy link

Hello,
I try using this instead the previous phosphor-react but found an issue It's failing to compile with my project, and had to revert.
seems similar to this issue on vue: phosphor-icons/vue#23

My project is using
react 18
rollup v3

The error

ERROR in ./node_modules/@phosphor-icons/react/dist/lib/IconBase.es.js 25:16
Module parse failed: Unexpected token (25:16)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|       ref: i,
|       xmlns: "http://www.w3.org/2000/svg",
>       width: t ?? o,
|       height: t ?? o,
|       fill: s ?? w,
 @ ./node_modules/@phosphor-icons/react/dist/icons/XSquare.es.js 3:0-38 35:52-53
 @ ./node_modules/@phosphor-icons/react/dist/index.es.js
 @ ./stories/timeStone/icons/icons.stories.jsx
 @ ./stories sync ^\.(?:(?:^|\/|(?:(?:(?!(?:^|\/)\.).)*?)\/)(?!\.)(?=.)[^/]*?\.stories\.(js|jsx|ts|tsx))$
 @ ./.storybook/generated-stories-entry.js
@rektdeckard
Copy link
Member

rektdeckard commented Mar 8, 2023

I guess we were a little overzealous targeting ESNext, I will rebuild for a more compatible target.

@rektdeckard
Copy link
Member

Have pushed up a new build. @phosphor-icons/react@2.0.5 is now built for ES2017 target and doesn't have any nullish-coalescing operators. LMK if that works for you!

@rektdeckard rektdeckard added the bug Something isn't working label Mar 8, 2023
@rektdeckard rektdeckard self-assigned this Mar 8, 2023
@rektdeckard
Copy link
Member

Resolved in v2.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants