Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue updating past 2.1.3 #94

Closed
johnnyshankman opened this issue Apr 16, 2024 · 2 comments
Closed

Issue updating past 2.1.3 #94

johnnyshankman opened this issue Apr 16, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@johnnyshankman
Copy link

johnnyshankman commented Apr 16, 2024

Describe the bug

After updating from 2.1.3 to 2.1.4 I can no longer run my vitests within a react 18 + node v20 + vite 5 repo, as phosphor starts throwing import errors.

Steps to Reproduce

Upgrade from 2.1.3 to 2.1.4 and watch vitest fail to resolve imports within phosphor.

Expected behavior

No import issues in vitest, like in 2.1.3.

Screenshots

Context (please complete the following information):

    "react": "^18.0.0",
    "react-dom": "^18.0.0",
    "react-router-dom": "^6.3.0"
    "@phosphor-icons/react": "2.1.4",
    "vite": "^5.2.7",
    "vitest": "^1.4.0",

Screenshot 2024-04-16 at 12 38 42 PM

Error: Cannot find package '/Users/johnshankman/Documents/manifoldxyz/studio-app-devtools/node_modules/@phosphor-icons/react/dist/node_modules/.pnpm/react@18.2.0/node_modules/react/package.json' imported from /Users/johnshankman/Documents/manifoldxyz/studio-app-devtools/node_modules/@phosphor-icons/react/dist/node_modules/.pnpm/react@18.2.0/node_modules/react/cjs/react-jsx-runtime.production.min.mjs
Did you mean to import react/index.js?

Additional notes

Downgrading back to 2.1.0 exactly produces no issues.

@johnnyshankman johnnyshankman added the bug Something isn't working label Apr 16, 2024
@johnnyshankman johnnyshankman changed the title Issue updating past 2.1.0 Issue updating past 2.1.3 Apr 16, 2024
@rektdeckard
Copy link
Member

Identified to be same issue as #90. Closing as duplicate, but fix incoming!

@rektdeckard rektdeckard closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2024
@johnnyshankman
Copy link
Author

@rektdeckard thank you! cheers. apologies for the dupe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants