Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date based event tagging #157

Closed
nomandera opened this issue Jan 4, 2021 · 3 comments
Closed

Date based event tagging #157

nomandera opened this issue Jan 4, 2021 · 3 comments

Comments

@nomandera
Copy link

I have a few ideas on TAGS that could be reliably automated. I hope this is the right medium to discuss them but if not please let me know.

It occurs to me that there are significant dates that based on your demographic, religion, country of origin may be worthy of tagging in and of themselves.

A few cherry picked example (no specific demographic intended, i just eyeballed a UK centric list as a starting point):

  • Christmas Day
  • Chinese New Year
  • Independence day
  • New Year (likely a multi hour event over the year turn and not a whole day)
  • Halloween
  • Guy Fawkes Night (likely a multi hour event in the evening only)
  • Yom Kippur (likely a multi day event)

There will not be universal set that fits every user but it doesn't seem like a huge step to make this quite an interesting and likely a quite reliable auto TAG feature.

A more advanced and likely less reliable extension to this would be analysing other TAGS in context

  • St Patricks Day + prominent colour green
  • Christmas Day + prominent colour red
  • Independence day when geotag also USA
  • Hogmany when when geotag also UK
@damianmoore
Copy link
Collaborator

Great idea and thanks for the list of events. Should be quite easy.

@damianmoore damianmoore added this to the 1.0 milestone Jan 4, 2021
@damianmoore damianmoore changed the title FEATURE: Date based event tagging Date based event tagging Feb 18, 2021
@damianmoore damianmoore added this to To do in Development tasks Apr 8, 2021
@damianmoore
Copy link
Collaborator

@GyanP I recommend looking at the color classifier as it's one of the simplest classifiers we have. Key files are:

  • photonix/photos/management/commands/classification_color_processor.py
  • photonix/photos/utils/classification.py
  • photonix/classifiers/color/model.py
  • photonix/classifiers/color/__init__.py
  • photonix/classifiers/color/info.py
  • photonix/classifiers/info.py

You'll need to create a new name for the model which will be event and a version which will be the date you start work on it (in case we refine it later and need to run it on the images again.

I like to start with getting the model running as a management command on single photos (like the first source file above) and then later get it running as via the DB Task processing system.

Let's go with these simple ones initially and then we can extend it later with more complex ones that depend on other classifiers (like location) and other calendars.

  • Christmas Day (25th December)
  • New Year (31st December 12:00PM to 1st January 12:00PM)
  • Halloween (31st October)
  • Valentine's Day (14th February)

A new tag filter will need to be added with associated GraphQL endpoints. When adding the tag to the search bar please re-use the same icon as generic tags use.

Screenshot_2021-04-08 Photonix Photo Manager(1)

@damianmoore damianmoore moved this from To do to In progress in Development tasks May 6, 2021
@damianmoore
Copy link
Collaborator

Merged as of 590cd4b. We can add more events later but we have good basis now.

Development tasks automation moved this from In progress to Done May 2021 Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development tasks
Done May 2021
Development

No branches or pull requests

3 participants