Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Face recognition snag list #285

Closed
5 tasks done
damianmoore opened this issue Jun 17, 2021 · 7 comments
Closed
5 tasks done

Face recognition snag list #285

damianmoore opened this issue Jun 17, 2021 · 7 comments
Assignees
Labels
Milestone

Comments

@damianmoore
Copy link
Collaborator

damianmoore commented Jun 17, 2021

  • Allow selecting text of face name input with mouse (swipes to next/previous photo)
  • Pressing Esc when editing a face tag name should cancel the change (currently returns user to thumbnails)
  • While in tag edit mode, clicking anywhere outside the text field should cancel the edit mode (no save).
  • In the filters on the main screen, "People" should be sorted so that the "Unknown person XXXXXX" ones are always at the bottom.
  • Allow hidden face tags (white boxes) to have label assign with an edit button in case they were accidentally removed.
@damianmoore damianmoore self-assigned this Jun 17, 2021
@damianmoore damianmoore added this to the 1.0 milestone Jun 17, 2021
@damianmoore damianmoore added this to To do in Development tasks Jun 17, 2021
@damianmoore damianmoore assigned GyanP and unassigned damianmoore Jun 18, 2021
@Linecutterx
Copy link

Suggestion: move the face tag editing behind a tap on the face which needs editing.
I took photos of a half marathon, with only one person of interest in most of the photos. The overlapping cloud of icons makes it near impossible to tag the correct face.

Additional request: tags for faces display within the face bounding box, which can mean <1 character is visible. Changing that would be great. (Different colored binding boxes & a legend with a key?

@GyanP
Copy link
Collaborator

GyanP commented Jun 28, 2021

Task done and pushed on branch 285-Face-recognition-snag. I have merged 279-hide-overlay-icons and 282-requestAnimationFrame-error in this branch.

@GyanP GyanP moved this from To do to Review in progress in Development tasks Jun 28, 2021
@damianmoore
Copy link
Collaborator Author

damianmoore commented Jul 8, 2021

@GyanP I don't think the person name sorting is working as I intended. Here, Zeema should be before Unknown XXXXXX.

Screenshot from 2021-07-08 18-56-19

@GyanP
Copy link
Collaborator

GyanP commented Jul 9, 2021

Hello Damian, I have sorted people by name (alphabetically). that's why Unknown Person 852439 displaying before Zeema. But if people tag name starts with any letter which occurs before U alphabetically that will display before Unknown Person 852439. And the tag name starts with letter which will occurs after U that will display after Unknown Person 852439.
If you want to sort people only to keep Unknown Person 852439 at the end then please let me know I have to customise the query for that.

@damianmoore
Copy link
Collaborator Author

Hi @GyanP. Yes, please make sure that all the "Unknown Person" tags are at the end (from the backend side).

@GyanP
Copy link
Collaborator

GyanP commented Jul 13, 2021

Updated the person filter query by adding some case for keeping Unknown Person tags always in last. I have also sorted tags alphabetically except Unknown person tag. Unknown Person tags always display in last. The task is done and changes pushed on branch 285-Face-recognition-snag

@damianmoore
Copy link
Collaborator Author

Thanks @GyanP. This is merged into master as of 98de1f5.

Development tasks automation moved this from Review in progress to Done June 2021 Jul 13, 2021
@damianmoore damianmoore moved this from Done June 2021 to Done Jul 2021 in Development tasks Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development tasks
Done Jul 2021
Development

No branches or pull requests

3 participants