Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo detail view #4

Closed
13 tasks done
damianmoore opened this issue Dec 29, 2018 · 5 comments
Closed
13 tasks done

Photo detail view #4

damianmoore opened this issue Dec 29, 2018 · 5 comments
Assignees
Milestone

Comments

@damianmoore
Copy link
Collaborator

damianmoore commented Dec 29, 2018

Detail view of photo showing camera attributes, tags, mini map, bounding boxes from object detection.

  • Modal view of photo which is on a higher z-index so main UI doesn't get redrawn on close.
  • Scroll down to see more details with animated indicator on first display and when hovering near bottom (no scroll bar will be displayed as we want photo to be as full screen as possible).
  • Scrolling down should make new pane float over photo without the photo moving - the pane might not be very tall and could control photo overlays such a bounding boxes. Make touch screen compatible too.
  • Location map and pin defaulting to a sensible zoom level
  • Colors display
  • Styles display
  • Camera settings display
  • Cross icon and ESC key to close modal
  • Star rating
  • Histogram
  • Full metadata display from exif
  • File path/name display
  • Move metadata overlay to be on the right with an icon to view it as scrolling down is not obvious
@PowerAnalyst
Copy link
Contributor

A back button to get from an enlarged photo back to the main interface would save having to use the browser controls.

Once I've narrowed down my search and opened an image, perhaps also a left/right function to slide through the photos selected.

@damianmoore
Copy link
Collaborator Author

Good suggestions @Soharic :)

@damianmoore damianmoore added this to To do in Development tasks via automation Jan 4, 2021
@damianmoore damianmoore self-assigned this Feb 18, 2021
@damianmoore
Copy link
Collaborator Author

@GyanP It would be great if you could help finish off these last couple of points.

Display the path at the bottom of the metadata panel:

Screenshot_2021-03-22 Photonix Photo Manager

Add a link to show more metadata:

Screenshot_2021-03-22 Photonix Photo Manager(2)

One the "More details" link is clicked, call new GraphQL query that runs the command exiftool FILE_PATH on the Photo's base_file and returns all exiftool's output. Display all of exiftool's output as a table inside the <Modal /> component, similar to how settings or the onboarding screens are displayed, over the photo detail screen.

Screenshot_2021-03-22 Photonix Photo Manager(3)

@damianmoore damianmoore assigned GyanP and unassigned damianmoore Mar 22, 2021
@GyanP
Copy link
Collaborator

GyanP commented Apr 2, 2021

Task done and changes pushed on branch 4-photo-detail-view

@damianmoore damianmoore moved this from To do to Review in progress in Development tasks Apr 4, 2021
@damianmoore
Copy link
Collaborator Author

Implemented as of 3bb6a71. A decision was made for simplicity reasons to display extra metadata as expandable area as it was hard to display a modal on top of a modal.

Development tasks automation moved this from Review in progress to Done Mar 2021 Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development tasks
Done Mar 2021
Development

No branches or pull requests

3 participants