Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot enlarge photos that have spaces in the filename #43

Closed
PowerAnalyst opened this issue Jan 4, 2019 · 6 comments
Closed

Cannot enlarge photos that have spaces in the filename #43

PowerAnalyst opened this issue Jan 4, 2019 · 6 comments
Labels

Comments

@PowerAnalyst
Copy link
Contributor

I've installed Photo Manager to my localhost:8888 and have the thumbnail images with all the current filters working to narrow down the images shown. If I click an image though, it takes me to a random url (different for each photo) which is just a plain black page, so I cannot view my photos enlarged.

For example, a photo labelled "2018-03-13 01 Bournemouth Station Sponsored Sign by Bournemouth University.JPG" takes me to a black screen "http://localhost:8888/photo/3259e783-f286-4c36-ae0f-f754f6a4df89"

@damianmoore
Copy link
Collaborator

Hi @Soharic. Thanks for the report.

The URI you are getting linked to with a random ID is to be expected - photos get assigned a UUID when they are first imported. This is a React router page that you get to but your image should be displaying scaled and centred on it.

When you get to this page could you right-click and "inpect element" to see if there are any clues? There should be an tag with a src including the file name. Could possibly be something to do with spaces in the filename or the JPEG not being decodable by the browser. Would be interesting to know if the download is 404ing.

@damianmoore damianmoore added the bug label Jan 4, 2019
@PowerAnalyst
Copy link
Contributor Author

PowerAnalyst commented Jan 4, 2019

@damianmoore it would appear to be due to the spaces in the file name. I've since added 3 photos without spaces "20181108_200511.jpg" etc and they all load perfectly well.

From the 'Elements inspection on Chrome' working images have <div class="PhotoDetail" style="background-image: url(&quot;/photos/20181108_200511.jpg&quot;);"></div> however for images with spaces in the name, this is simply <div class="PhotoDetail"></div>

@damianmoore
Copy link
Collaborator

#28 will eventually alter what image downloads here so should be a bit more robust then.

@damianmoore
Copy link
Collaborator

Thanks for the update @Soharic. I'll work on fixing the filename spaces issue.

@PowerAnalyst
Copy link
Contributor Author

Thanks for the update @Soharic. I'll work on fixing the filename spaces issue.

Sounds great, thank you! The way I label my photos, they've all got spaces in...

@damianmoore damianmoore changed the title Cannot enlarge photos Cannot enlarge photos that have spaces in the filename Jan 4, 2019
@damianmoore
Copy link
Collaborator

Pretty sure this is solved now that all images shown go through the thumbnailer @Soharic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants