Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error in TypeScript definitions: arguments of instance method Phaser.InputHandler.start should be optional #537

Closed
bseiller opened this issue May 8, 2018 · 1 comment
Closed

error in TypeScript definitions: arguments of instance method Phaser.InputHandler.start should be optional #537

bseiller opened this issue May 8, 2018 · 1 comment
Labels
typescript
Milestone
2.10.6

Comments

@bseiller
Copy link

bseiller commented May 8, 2018

An error in the TypeScript definitions:

phaser.comments.d.ts and phaser.d.ts define both parameters of the instance method Phaser.InputHandler.start as not optional.

Thanks for the great work!
@samme samme added this to the 2.10.6 milestone May 21, 2018
@Weedshaker
Copy link
Contributor

I assume you just do start?: number
although, I am not sure if that is the right location. I don't have any phaser setup with typescript, but make the change, test it at your setup -> PR.

@samme samme closed this as completed in e58269d Jun 1, 2018
@samme samme removed the help wanted label Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
2.10.6
Development

No branches or pull requests
3 participants
@samme @Weedshaker @bseiller