Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tile#properties unclear and cause problems with implementation usage (ie. A*) #1254

Closed
pnstickne opened this issue Oct 26, 2014 · 0 comments
Closed

Tile#properties unclear and cause problems with implementation usage (ie. A*) #1254

pnstickne opened this issue Oct 26, 2014 · 0 comments

Comments

@pnstickne
Copy link
Contributor

Tile#properties should really be called Tile#propertiesForTilesWithThisIndex.These properties are shared between all Tiles in the tile map with the same tile index, as they are merely "references" to the applicable tile set properties.

Some plugins (ie. A*) assume that these properties are distinct-per-tile, which does not hold now even if it did at one point.

Furthermore, if a tile index is changed these properties refer to the now incorrect tile-index properties.
photonstorm added a commit that referenced this issue Feb 11, 2015
@photonstorm
Tile.properties is now unique to that specific Tile, and not a refere…
daf8440 
…nce to the Tileset index bound properties object. Tile.properties can now be modified freely without impacting other tiles sharing the same id (#1254)
@snyk-bot snyk-bot mentioned this issue Sep 17, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@photonstorm @pnstickne