Sprite Animations are not removed completely.

[Arturszott]

There is a problem with memory leak. When you will add looped animation to the sprite, it somehow holds the sprite in memory after using sprite's destroy method preventing garbage collector to free the memory.

[photonstorm]

Can you prove this through with a profile dump / timeline evidence please.

[Arturszott]

https://dl.dropboxusercontent.com/u/22040534/Heap-20141212T195649.heapsnapshot

[photonstorm]

I have added in some extra checks and reference clearing in the dev branch, so if you could build and test against that it'd be good thanks

[photonstorm]

Ok I tested this against 2.3-dev. The example I used creates 1 new looped animated sprite every 50ms. I let it run until it had destroyed 2500 sprites and checked the memory profile in dev tools and it was fine - a bit of gc every 30 seconds or so, but memory never went beyond 21MB. So I'm happy this is resolved.

var game = new Phaser.Game(800, 600, Phaser.CANVAS, 'phaser-example', { preload: preload, create: create, update: update, render: render });

function preload() {

    game.load.spritesheet('mummy', 'assets/sprites/metalslug_mummy37x45.png', 37, 45, 18);

}

var sprites;
var rip = 0;

function create() {

    sprites = game.add.group();

    game.time.events.loop(50, createSprite, this);

}

function createSprite() {

    var mummy = sprites.create(0, game.world.randomY, 'mummy');

    mummy.animations.add('walk');

    mummy.play('walk', 10, true);

}

function update() {

    sprites.setAll('x', 10, true, true, 1);

    sprites.forEach(checkSprite, this, true);

}

function checkSprite(sprite) {

    try {
        if (sprite.x > game.width)
        {
            rip++;
            sprites.remove(sprite, true);
        }
    }
    catch (e)
    {
        console.log(sprite);
    }

}

function render() {

    game.debug.text("Group size: " + sprites.total, 32, 32);
    game.debug.text("Destroyed: " + rip, 32, 64);

}