Changing text property of tinted BitmapText doesn't use correct glyphs

[Pajamaman]

Add a BitmapText to the game and give it a tint:

var game = new Phaser.Game(320, 200, Phaser.AUTO, '', {preload: preload, create: create}),
    text;

function preload() {
    game.load.bitmapFont('desyrel', 'desyrel.png', 'desyrel.xml');
}

function create() {
    text = game.add.bitmapText(0, 0, 'desyrel', 'bar', 64);
    text.tint = 0x55ff55;
}

Once the page loads, type this in the console:

text.text = 'foobar';

Result:

As a workaround, you can type this in the console after setting the text:

text.removeChildren();
text.purgeGlyphs();

Correct result:

I'm using Phaser 2.4.2 and Chromium 43.0.2357.130 Ubuntu 14.04 (64-bit).

[Cristy94]

I think .text property is read only, and you should use text.setText('foobar') instead. http://phaser.io/docs/2.3.0/Phaser.BitmapText.html#setText

[Pajamaman]

Same result with setText().

[Cristy94]

What about calling .updateText() after you set it?

[Pajamaman]

.updateText() is called by the text property setter. In other words, nope.

I think the fix for this is to change line 372 of BitmapText.js from this:

var g = this._glyphs[t];

To this:

var g = Phaser.Group.prototype.filter.call(this, function (glyph) { return glyph.name == line.text[c] }).list[0];

I don't see anywhere else in the source where a method from another class is called like this however. If this goes against convention or is just too ugly, we could put the filter method into Utils or something. It could even be made static.

Another fix is to change line 374 from this:

if (g)

To this:

if (g && g.name == line.text[c])

I don't like this because I don't think we should assume that this._glyphs[t] will be the glyph we're looking for.

Of course we could always use Array.prototype.filter but I don't see that anywhere else in the source either. I assume this is because Phaser is meant to support older browsers.

[photonstorm]

Actually I think it's directly related to this: 9362a2b

[photonstorm]

This is now fixed in a dev - and didn't require anything as intense as any of the suggestions above thankfully :)

[Pajamaman]

Oh, hah. That's much simpler indeed. Thanks for the speedy fix!

[DDowell]

I still get it in 2.6.1 albeit not as frequent. I first had the setText outside of the phaser game loop but even after moving it into the game loop, it happens from time to time.