Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phaser.Math.RND.sign property and method collision #3323

Closed
vinerz opened this issue Mar 5, 2018 · 1 comment · Fixed by #3325
Closed

Phaser.Math.RND.sign property and method collision #3323

vinerz opened this issue Mar 5, 2018 · 1 comment · Fixed by #3325

Comments

@vinerz
Copy link

vinerz commented Mar 5, 2018 •
edited

Issue type: A bug in the API
Phaser version: 3.2.0

Hey guys! I can not express words for how awesome this project is.
I am deeply diving into Phaser 3 for a mid-complex project and it is amazing so far.

I got into trouble trying to use the Phaser.Math.RND.sign, as it also declares sign as its own property inside the constructor and overrides the method.

My suggestion would be to change the property to _sign and keep the method as is.

Thanks again! 😆
samme added a commit to samme/phaser that referenced this issue Mar 5, 2018
@samme
Fix property name conflict in Phaser.Math.RandomDataGenerator#sign
9234fd1 
Fixes phaserjs#3323
@samme samme mentioned this issue Mar 5, 2018
Merged
@photonstorm
Copy link
Collaborator

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix property name conflict in Phaser.Math.RandomDataGenerator#sign samme/phaser
2 participants
@photonstorm @vinerz