Reset the current animation. #1029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When going from an animating Sprite with multiple frames to an image with 1 frame, the AnimationManager keeps setting invalid frames upon the single-frame image. This fix may not be correct for it overwrites the currentAnimation _always_…
photonstorm
added a commit
that referenced
this pull request
Jul 15, 2014
…er which will halt the currently running animation (if any) after changing the texture (based on #1029).
|
Yes good point. I've added in an optional |
|
Yesss! Your 2nd commit (updateFrameData) was what I was hoping for. Thanks a lot! mySprite.loadTexture("car"); Is not that big a deal. |
|
Also, shouldn't updateFrameData check for an out of bounds error with some kind of mod? this._frameData.getFrame(this._frames[this._frameIndex % this._frames.length]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When going from an animating Sprite with multiple frames to an image
with 1 frame, the AnimationManager keeps setting invalid frames upon
the single-frame image.
This fix may not be correct for it overwrites the currentAnimation
always…