DOM.visualBounds now includes scrollbars #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- While not ideal this fixes most (if not all) of the ScaleManager issue pointed out in phaserjs#1400. This issue should be addressed later. As of now, as an interim fix, this avoids the reported issue entirely (or at least I have not been able to reproduce it), as well as assorted artifacts when resizign a window while scaling. - The is is the 2.1 behavior: In certain cases this can result in the right or bottom of the Game being cut-off slightly (the width of a scrollbar) instead of scaled, which is why it was originally changed.
photonstorm
added a commit
that referenced
this pull request
Dec 11, 2014
DOM.visualBounds now includes scrollbars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pointed out in setResizeCallback needs clamping #1400. This issue should be addressed later. As of now,
as an interim fix, this avoids the reported issue entirely (or at least
I have not been able to reproduce it), as well as assorted artifacts
when resizign a window while scaling.
right or bottom of the Game being cut-off slightly (the width of a
scrollbar) instead of scaled, which is why it was originally changed.