Fix WebAudio for Crodova based apps #6010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Can you please remove all of the dist files, package-lock and types from it, as I cannot merge those. |
|
I removed dist files, package-lock and types. I also merged latest changes from master. |
photonstorm
added a commit
that referenced
this pull request
May 9, 2022
… Loader considers as being local files. This is populated by the new `Phaser.Core.Config#loaderLocalScheme` game / scene config property. It defaults to `[ 'file://', 'capacitor://' ]` but additional schemes can be defined or pushed onto this array. Based on #6010
|
Thanks, I've merged this in and tweaked it a bit, so you can now specify an array of local schemes in the config, rather than just one. It's also available via the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not update the README or Change Log, we will do this when we merge your PR.
This PR (delete as applicable)
Describe the changes below:
When using Cordova, WebAudio doesn't work. It was fixed for Capacitor by adding check in
src/loader/File.jsthatxhr.responseUrlstarts withcapacitor://. We are using different scheme for Cordova and it was not working for us. I've added configuration option to specify custom scheme to properly recognise if file is local and load sound file properly.