Removing filters when destroying a group. #844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a filter is applied to the world it is not removed when the group is destroyed. This clears up the filters variable as also done in sprites.
|
Sorry, that should have been on the dev branch. |
photonstorm
added a commit
that referenced
this pull request
May 26, 2014
|
Thanks, I can't merge (because master) but have applied it locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a filter is applied to the world it is not removed when the group (which it inherits the prototype from) is destroyed. This clears up the filters variable as also done in sprites.
I'm not entirely sure what is best practice in the grand scheme of things though, perhaps this is required functionality and filters should not be applied at world level.