Fix getPixel for pixels with zero red value. #894
Merged
+4
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove an erroneous if that causes getPixel() to fail if the red value of the pixel is zero. Fixes #881.
|
The Travis build fails on jshinting, but that's on another part of the code. My change lints perfectly 👍 |
photonstorm
added a commit
that referenced
this pull request
Jun 10, 2014
Fix getPixel for pixels with zero red value.
|
👍 |
photonstorm
added a commit
that referenced
this pull request
Jun 10, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove an erroneous
ifthat causesgetPixel()to fail if the red value of the pixel is zero.I'm not sure what the original intent of the if check was, and I have made no attempt to preserve that intent. It is possible that it wanted to avoid out-of-bounds access, in which case a
try/catchwould probably be better.Fiddle with bug: http://jsfiddle.net/FxjL8/11/
Fiddle after fixing the bug: http://jsfiddle.net/FxjL8/13/
In the first fiddle, clicking on green, blue or cyan will return a blank color object. In the second fiddle, it works for all colors.
Fixes #881.