Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"disable Adblocker" prompt even though I'm not blocking Ads #6737

Closed
Krazyplays opened this issue May 10, 2024 · 2 comments
Closed

"disable Adblocker" prompt even though I'm not blocking Ads #6737

Krazyplays opened this issue May 10, 2024 · 2 comments

Comments

@Krazyplays
Copy link

Krazyplays commented May 10, 2024

Your Operating System: Windows 10
Your Web Browser: Firefox
The problem happens in the Incognito Mode, too: Yes

This must be done to see the problem

  1. Go to www.photopea.com
    Done

"disable Adblocker" prompt even though I'm not blocking Ads
Quick Info: I did read the article about disabling adblock for photopea

I found 2 problems with your ad-display-system.

  1. Firefox comes with an antitrack feature (killing fingerprints and trackers) and the default setting (which is by no means meant to kill ads, only its tracking) kills your ad display. It doesn't show any prompt or custom ads, just nothing (maybe it does after some time, idk, but if, that also shouldn't be ig). I really suggest looking into that, the Anti-tracking feature is on by default and its really not meant to break ads and shouldnt need to be turned off.
  2. I'm using the Windscribe (VPN) addon, which builds upon the UBlock addon (meaning its adblock functionality is just Ublocks code imbedded into the addon). In any case: You can whitelist any website each from the VPN connection and adblock functionality. But theres also the setting to block some trackers, that isn't meant to stop ads from working and that can't be turned off for individual websites.

Idk if someone mentioned the issue I'm trying to point out here and I'm sorry if, but your ad-display-system seems to stop working, when that of other websites doesnt.

I've also done a quick test on this website, each with everything on, the site whitelisted on every addon (but Firefox's & Windscribe's anti tracker on) and everything disabled.
Result was that disabling everything made no difference to just whitelisting the website on addons, resulting at "3%" Blockage (remaining seem Brand specific) and with "blocking on" resulting at 99%. Ofc that test might make no relevant statement in this case but I'm only trying to make a quick issue report here.

Hope this somehow helped, really like your product and think that improving on this could be crucial to support Photopea through ads.

@photopea
Copy link
Owner

I just opened www.Photopea.com in the latest release of Firefox, installed at default settings, and the ads are displayed correctly.

If Photopea notices at least one domain which it can not access, we consider it to be ad-blocking.

@photopea
Copy link
Owner

I have to close it because of lack of details :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants