Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for scikit-image > 0.20.0 #365

Open
snk4tr opened this issue Jun 4, 2023 · 0 comments
Open

Update tests for scikit-image > 0.20.0 #365

snk4tr opened this issue Jun 4, 2023 · 0 comments
Labels
feature New feature or request

Comments

@snk4tr
Copy link
Contributor

snk4tr commented Jun 4, 2023

Is your feature request related to a problem? Please describe.
The latest scikit-image release (v0.21.0) changed the default shape of loaded tensors, which broke at least tests for BRISQUE but presumably all image loading-related tests. Temporary solution in #348 is to freeze scikit-image==0.20.0 in the CI testing pipeline.

Describe the solution you'd like
We may need to update tests to handle future scikit-image versions.

Describe alternatives you've considered
We might leave it as is for now.

Additional context
The failed job with scikit-image==0.21.0. The fixed job with lowerred scikit-image version to 0.20.0.
@snk4tr snk4tr added the feature New feature or request label Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@snk4tr