Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Screen Images #4

Open
ryanmac8 opened this issue Feb 22, 2022 · 6 comments
Open

Full Screen Images #4

ryanmac8 opened this issue Feb 22, 2022 · 6 comments

Comments

@ryanmac8
Copy link

Hey,
What needs to be done to support full screen mode? I was able to remove the comments and it looks to be working fine but wanted to get your input. Also, is there a roadmap for this project? If so, I don't mind trying to help you out and get some features implemented.

.onTapGesture { // Disabled until a better solution is made mediaEnv.fullScreen = !fullscreenMode }

@wrick17
Copy link

wrick17 commented Jul 3, 2022

This looks like a good solution for the time being. I mean it won't hurt functionality.
@viktorstrate Thoughts?

@ferni7
Copy link

ferni7 commented Jul 10, 2022

@ryanmac8 @wrick17 Any updates on getting full screen images? I care more about this than viewing photo metadata on my phone

@ferni7
Copy link

ferni7 commented Jul 16, 2022

@ryanmac8 Any chance you can put a PR in for your change?

@wrick17
Copy link

wrick17 commented Oct 22, 2022

@viktorstrate @ryanmac8 any update on this? This would really be a huge game-changer for this app. I don't have any other major gripes.

@ryanmac8
Copy link
Author

I opened up a PR but only the developer can merge it in, which seems unlikely due to having no response about this issue.
#17

@ddshd
Copy link
Contributor

ddshd commented Mar 1, 2023

Opened up a PR with a small redesign of the image/video viewing system.. It should look more like a "normal" gallery app.. #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants