Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need for the PUBLIC_ENDPOINT environment variable when running API and UI on the same host #218

Closed
viktorstrate opened this issue Feb 26, 2021 · 0 comments
Labels
API Related to the backend api server written in Go
Projects

Comments

@viktorstrate
Copy link
Member

The two use cases for the environment variable PHOTOVIEW_PUBLIC_ENDPOINT is:

  • To provide Cross-Origin Resource Sharing (CORS)
  • To add full URL paths for images.

But if Photoview is configured to use the same host for both the API and the UI, both of these are not needed. CORS is not needed as it's not Cross-Origin and full URL paths could just be the full path without the domain.

@viktorstrate viktorstrate added the API Related to the backend api server written in Go label Feb 26, 2021
@viktorstrate viktorstrate added this to To do in Roadmap via automation Feb 26, 2021
@viktorstrate viktorstrate moved this from To do to Before next release in Roadmap Feb 26, 2021
@viktorstrate viktorstrate moved this from Before next release to To do in Roadmap Feb 26, 2021
@viktorstrate viktorstrate moved this from To do to Before next release in Roadmap Feb 27, 2021
@viktorstrate viktorstrate moved this from Before next release to In progress in Roadmap Mar 1, 2021
@viktorstrate viktorstrate moved this from In progress to Done in Roadmap Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to the backend api server written in Go
Projects
Development

No branches or pull requests

1 participant