Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Error when trying to download photo #238

Closed
kaiiiz opened this issue Mar 4, 2021 · 1 comment
Closed

Bug: Error when trying to download photo #238

kaiiiz opened this issue Mar 4, 2021 · 1 comment
Labels
bug Something isn't working
Projects

Comments

@kaiiiz
Copy link

kaiiiz commented Mar 4, 2021

Describe the bug
When downloading photo, the following error occurs in console:

Uncaught (in promise) TypeError: Failed to construct 'URL': Invalid URL
    at yt (chunk.3GYKX56M.js:63)
    at onClick (chunk.3GYKX56M.js:65)
    at Object.wa (chunk.PDZ5WKFG.js:5)
    at Sa (chunk.PDZ5WKFG.js:5)
    at Ea (chunk.PDZ5WKFG.js:5)
    at Lu (chunk.PDZ5WKFG.js:5)
    at gu (chunk.PDZ5WKFG.js:5)
    at chunk.PDZ5WKFG.js:5
    at Bo (chunk.PDZ5WKFG.js:9)
    at ga (chunk.PDZ5WKFG.js:5)

To Reproduce

  1. Go to demo site
  2. Randomly pick one photo
  3. Click any of download buttons in the right tab

Expected behavior
Should download without problem.

Screenshots
image

Additional context
It is a little off topic, but I found that the button group in sharing options would overflow when the width of window getting smaller.

Setting flex-wrap: wrap in the wrapper may helps a little bit, but the style (alignment) inside button may take into consideration.

image

@kaiiiz kaiiiz added the bug Something isn't working label Mar 4, 2021
@viktorstrate
Copy link
Member

Thank you for the detailed explaination and style suggestion.
I must have missed testing downloads after removing the PHOTOVIEW_PUBLIC_ENDPOINT environment variable.

@viktorstrate viktorstrate added this to To do in Roadmap via automation Mar 5, 2021
Roadmap automation moved this from To do to Done Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants