-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Photoview page "crashes" when trying to display sidebar for media with invalid gps data #850
Comments
@lesensei, please share an example image with such incorrect GPS data, so that we can try to reproduce the issue on our side. You can use some file sharing service and post here a link to the file, but please put it into an archive without password to make sure that no intermediate service parser is modifying it |
P1020746.zip |
Thanks @lesensei , with this image I've reproduced the issue.
17:53:32.859 Error: Invalid LngLat latitude value: must be between -90 and 90
bt http://localhost:8000/assets/mapbox-gl.fe42628b.js:8
convert http://localhost:8000/assets/mapbox-gl.fe42628b.js:8
jumpTo http://localhost:8000/assets/mapbox-gl.fe42628b.js:1081
Map http://localhost:8000/assets/mapbox-gl.fe42628b.js:1085
Ee http://localhost:8000/assets/MapboxMap.02a5fa61.js:86
eu http://localhost:8000/assets/index.9b57b0a0.js:32
ni http://localhost:8000/assets/index.9b57b0a0.js:32
zb http://localhost:8000/assets/index.9b57b0a0.js:32
S http://localhost:8000/assets/index.9b57b0a0.js:17
J http://localhost:8000/assets/index.9b57b0a0.js:17
EventHandlerNonNull* http://localhost:8000/assets/index.9b57b0a0.js:17
<anonymous> http://localhost:8000/assets/index.9b57b0a0.js:17
index.9b57b0a0.js:32:175
gc http://localhost:8000/assets/index.9b57b0a0.js:32
callback http://localhost:8000/assets/index.9b57b0a0.js:32
Ud http://localhost:8000/assets/index.9b57b0a0.js:30
oh http://localhost:8000/assets/index.9b57b0a0.js:32
ly http://localhost:8000/assets/index.9b57b0a0.js:32
Db http://localhost:8000/assets/index.9b57b0a0.js:32
zb http://localhost:8000/assets/index.9b57b0a0.js:32
sn http://localhost:8000/assets/index.9b57b0a0.js:32
uh http://localhost:8000/assets/index.9b57b0a0.js:32
nn http://localhost:8000/assets/index.9b57b0a0.js:30
ni http://localhost:8000/assets/index.9b57b0a0.js:32
zb http://localhost:8000/assets/index.9b57b0a0.js:32
S http://localhost:8000/assets/index.9b57b0a0.js:17
J http://localhost:8000/assets/index.9b57b0a0.js:17
(Async: EventHandlerNonNull)
<anonymous> http://localhost:8000/assets/index.9b57b0a0.js:17
<anonymous> http://localhost:8000/assets/index.9b57b0a0.js:17 17:53:32.861 Uncaught Error: Invalid LngLat latitude value: must be between -90 and 90
bt http://localhost:8000/assets/mapbox-gl.fe42628b.js:8
convert http://localhost:8000/assets/mapbox-gl.fe42628b.js:8
jumpTo http://localhost:8000/assets/mapbox-gl.fe42628b.js:1081
Map http://localhost:8000/assets/mapbox-gl.fe42628b.js:1085
Ee http://localhost:8000/assets/MapboxMap.02a5fa61.js:86
eu http://localhost:8000/assets/index.9b57b0a0.js:32
ni http://localhost:8000/assets/index.9b57b0a0.js:32
zb http://localhost:8000/assets/index.9b57b0a0.js:32
S http://localhost:8000/assets/index.9b57b0a0.js:17
J http://localhost:8000/assets/index.9b57b0a0.js:17
EventHandlerNonNull* http://localhost:8000/assets/index.9b57b0a0.js:17
<anonymous> http://localhost:8000/assets/index.9b57b0a0.js:17
mapbox-gl.fe42628b.js:8:66553
bt http://localhost:8000/assets/mapbox-gl.fe42628b.js:8
convert http://localhost:8000/assets/mapbox-gl.fe42628b.js:8
jumpTo http://localhost:8000/assets/mapbox-gl.fe42628b.js:1081
Map http://localhost:8000/assets/mapbox-gl.fe42628b.js:1085
Ee http://localhost:8000/assets/MapboxMap.02a5fa61.js:86
eu http://localhost:8000/assets/index.9b57b0a0.js:32
ni http://localhost:8000/assets/index.9b57b0a0.js:32
zb http://localhost:8000/assets/index.9b57b0a0.js:32
S http://localhost:8000/assets/index.9b57b0a0.js:17
J http://localhost:8000/assets/index.9b57b0a0.js:17
(Async: EventHandlerNonNull)
<anonymous> http://localhost:8000/assets/index.9b57b0a0.js:17
<anonymous> http://localhost:8000/assets/index.9b57b0a0.js:17 I thinks that the best way to fix this issue is to add the GPS data validation after it is extracted from the file by the scanner job and before it is stored in the DB:
|
Describe the bug
One of our family camera seems to use a default "max" value for latitude and longitude data when the GPS can't fix a position. This translates to the following:
The scanner doesn't choke on this and integrates the values in the database (with maker/model for ref):
However, the problem arises when trying to display the info sidebar for one of the affected pictures (from the dev console):
This actually results in an empty webpage (empty
div#root
), and I need to reload the whole page (ctrl-r or F5) to resume navigating my photos.To Reproduce
Steps to reproduce the behavior:
Expected behavior
Either sanitize gps values before calling mapbox widget or when scanning media before saving exif data to db.
Your environment:
Feel free to remove and add what you think might be useful.
Thanks for this software !
The text was updated successfully, but these errors were encountered: