Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve selectable Album thumbnail #89

Open
FelixUster opened this issue Sep 25, 2020 · 6 comments
Open

Improve selectable Album thumbnail #89

FelixUster opened this issue Sep 25, 2020 · 6 comments
Labels
feature A new idea or feature

Comments

@FelixUster
Copy link

Hey,

thank you very much for this project. It is basically what I am looking for.
It would be great, if it would be possible to select the album thumbnail, instead of using the earliest Picture in a folder.
of course, I am willing to help, maybe you can hint me to the respective file, as I have never used JS or Go.

@viktorstrate
Copy link
Member

Hi @FelixUster

I think this is would be a nice feature.
It could be implemented in a similar way as how Google Photos does it. Clicking a button labeled "Use as album cover".

If you have very little experience with Javascript and Go, then I think it would be quite ambitious to implement this.
But if you want to give it a shot nevertheless, here are the basic steps:

  • Add a database migration where a new column is added for a potential cover image, referencing the media_id of the selected cover image.
  • Add and implement a graphql mutation to change the cover of an album.
  • Update the album thumbnail resolver to use the selected album cover if set, otherwise use the current implementation to dynamically select the first one.
  • Integrate the graphql mutation into the web interface.

@viktorstrate
Copy link
Member

Implemented in #526

@jiangzhenjerry
Copy link

Hi! Sorry for bumping a closed ticket. I do enjoy the "Set as album cover photo" function, so thanks for implementing it. On the other hand, maybe one day this feature could be extended a bit? For example, for the following folder structure:

Folder A
├── Folder B
│   ├── 1.jpg
│   └── 2.jpg
└── Folder C
    ├── 3.jpg
    └── 4.jpg

We can now easily change the cover photos of Folder B and Folder C, but not that of Folder A because Folder A doesn't have any photos directly under it.

Furthermore, if I change the cover photo of Folder B to 2.jpg (from 1.jpg by default), Folder A would still use 1.jpg (first photo in the first subfolder) as the cover photo. It would be nice if Folder A at least follows my choice of cover photo for Folder B.

@viktorstrate viktorstrate reopened this Oct 7, 2021
@viktorstrate viktorstrate changed the title Selectable Album thumbnail Improve selectable Album thumbnail Oct 7, 2021
@EgonHeuson
Copy link

This would be an amazing feature!! ❤️ But Photoview is already a very nice job! Thanks!!

@hcooper
Copy link

hcooper commented Jan 26, 2023

+1 controlling the album cover of a parent album would be great.

@Lingxi-Li
Copy link

+1 for the feature to set cover page of albums that contain no photo but only sub-albums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new idea or feature
Projects
None yet
Development

No branches or pull requests

6 participants