Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Navbar too small on overflowing pages #140

Closed
puehringer opened this issue Aug 1, 2019 · 1 comment
Closed

Navbar too small on overflowing pages #140

puehringer opened this issue Aug 1, 2019 · 1 comment

Comments

@puehringer
Copy link
Contributor

puehringer commented Aug 1, 2019

  • Release number or git hash: 2.1.1
  • Web browser version and OS: Chrome Version 75.0.3770.142
  • Environment (local or deployed): Local and Deployed

Steps to reproduce

  1. Visit https://stratomex.caleydoapp.org (or any app utilizing the phovea header)
  2. Force the page into scrolling mode (by opening dev tools for example)

Observed behavior

Navbar is becoming too small (not fitting to content, but min-width: 28px)
Peek 2019-08-01 08-37

Expected behavior

  • Navbar size stays the same (fits content).

Possible fix

Remove the height: 100% in https://github.com/phovea/phovea_clue/blob/develop/src/styles/_base.scss#L103
This fixes the navbar, but side effects may occur.
Alternatively, the navbar min-height can be changed from 28px to auto to always fit the content. This is defined in phovea_ui (https://github.com/phovea/phovea_ui/blob/develop/src/styles/_header_navbar.scss#L7).

@thinkh
Copy link
Contributor

thinkh commented Sep 12, 2019

Issue moved to phovea/phovea_ui #68 via ZenHub

@thinkh thinkh closed this as completed Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants