Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 support issue #903

Closed
patrickkusebauch opened this issue Mar 6, 2021 · 1 comment · Fixed by #904
Closed

PHP 8 support issue #903

patrickkusebauch opened this issue Mar 6, 2021 · 1 comment · Fixed by #904

Comments

@patrickkusebauch
Copy link
Contributor

Hey, I know there was a push for PGP8 support in this repo (393546c). There is still at least one dangling issue that needs to be resolved. Just FYI, since I am trying to get this library working on PHP8 right now.

php-amqplib/PhpAmqpLib/Helper/Protocol/Protocol080.php

Line 299 in b2856aa

$exchange,

@patrickkusebauch
Copy link
Contributor Author

One more a few lines later:

php-amqplib/PhpAmqpLib/Helper/Protocol/Protocol080.php

Line 334 in b2856aa

public function exchangeDelete($ticket = 1, $exchange, $if_unused = false, $nowait = false)

@patrickkusebauch patrickkusebauch mentioned this issue Mar 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PHP 8 support
1 participant
@patrickkusebauch