Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "no_ack" consumer option (feature request) #717

Closed
andrey-tech opened this issue Nov 2, 2023 · 3 comments · Fixed by #718
Closed

Add "no_ack" consumer option (feature request) #717

andrey-tech opened this issue Nov 2, 2023 · 3 comments · Fixed by #718

Comments

@andrey-tech
Copy link
Contributor

Hello!

Please, add important configuration option for consumer no_ack. If set to true, automatic acknowledgement mode will be used by consumer. The default value is false.

We really need this option on our large project at the moment, but no_ack value is hardcoded to false in method setupConsumer() of classes:

  • OldSound\RabbitMqBundle\RabbitMq\BaseConsumer,
  • OldSound\RabbitMqBundle\RabbitMq\BatchConsumer,
  • OldSound\RabbitMqBundle\RabbitMq\MultipleConsumer.

E.g. https://github.com/php-amqplib/RabbitMqBundle/blob/master/RabbitMq/BaseConsumer.php#L71

        $this->getChannel()->basic_consume($this->queueOptions['name'], $this->getConsumerTag(), false, false, false, false, [$this, 'processMessage']);
@andrey-tech
Copy link
Contributor Author

andrey-tech commented Nov 5, 2023

@mihaileu Do you accept PR now? Аny chance to include the changes from my PR to your new release in the next month?

@mihaileu
Copy link
Collaborator

mihaileu commented Nov 7, 2023

looking into

@mihaileu
Copy link
Collaborator

mihaileu commented Nov 7, 2023

thx for your support, new tag was created: 2.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants