Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I hope it can be used under the lumen project at the same time? #38

Closed
dafa168 opened this issue Dec 27, 2021 · 10 comments · Fixed by #39
Closed

I hope it can be used under the lumen project at the same time? #38

dafa168 opened this issue Dec 27, 2021 · 10 comments · Fixed by #39
Labels
enhancement New feature or request

Comments

@dafa168
Copy link

dafa168 commented Dec 27, 2021 •
edited

强烈希望可以同时在lumen项目下使用， 目前我们公司项目大多数都采用的是lumen框架搭建的；
在安装php-casbin/laravel-authz的时候会报错，提示：必须在laravel上才能使用；
强制安装上之后，发现Laravel框架核心也被安装上了， 这样会导致项目vendor目录非常大。
所以希望发个能在lumen上使用的版本，谢谢。
@hsluoyz
Copy link
Member

hsluoyz commented Dec 27, 2021

@techoner can we create a new repo?

@dafa168
Copy link
Author

dafa168 commented Dec 28, 2021

其实没有必要新建一个仓库。
1、去掉必须要laravel核心的条件；
2、在ServiceProvider中兼容lumen；
3、在使用方法中，增加关于lumen的使用方法；
4、最好不和Auth::User() 做强耦合。

@leeqvip leeqvip changed the title 希望可以同时在lumen项目下使用??? I hope it can be used under the lumen project at the same time? Dec 28, 2021
@leeqvip leeqvip added the enhancement New feature or request label Dec 28, 2021
@leeqvip
Copy link
Member

leeqvip commented Dec 28, 2021

@dafa168 Can you make a PR ?

@hsluoyz
Copy link
Member

hsluoyz commented Dec 28, 2021

@basakest

@dafa168
Copy link
Author

dafa168 commented Dec 29, 2021 •
edited by leeqvip

@dafa168 Can you make a PR ?

I'm so sorry, I've been very busy at work recently.

@hsluoyz
Copy link
Member

hsluoyz commented Dec 29, 2021

@basakest can you work on this?

@phpxcn
Copy link

phpxcn commented Jan 18, 2022 •
edited by leeqvip

When will the available version of lumen be released?

@leeqvip
Copy link
Member

leeqvip commented Jan 18, 2022

@phpxcn Maybe a week or more.

@leeqvip leeqvip linked a pull request Jan 28, 2022 that will close this issue
feat: compatible with lumen #39
Merged
@leeqvip
Copy link
Member

leeqvip commented Jan 28, 2022

@dafa168 @phpxcn The latest version is already compatible with lumen .

@hsluoyz
Copy link
Member

hsluoyz commented Jan 28, 2022

See: https://github.com/php-casbin/laravel-authz/releases/tag/v3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: compatible with lumen php-casbin/laravel-authz
4 participants
@phpxcn @dafa168 @hsluoyz @leeqvip