-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search crashes: Invalid method PHPCuong\Faq\Block\Search\Search::filterProvider #22
Comments
I have created a pull request to fix this issue. Check #23 |
@SherifElfadaly great patch! I can confirm the patch is working and to me it should be merged to master as soon as possibile since at the current state the search functionality is broken. |
@SherifElfadaly fixed a part of the search results. I searched with more than 3 words which were copied from one of the answers. But results listed all questions in my English Store (some times it also included all questions from my other Chinese Store) |
@lamaithanh I know this is years later but the query is not built correctly when there are multiple keywords. You can correct this by adding parenthesis to the query at line 175 like this:
|
If you search for something that matches a value the search will crash
/faq/search/?s=feet
If you search for something with no matches it returns fine
/faq/search/?s=xxxxx
I was able to replicate this on 2.1.7 and 2.1.7.1
The text was updated successfully, but these errors were encountered: