Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Deprecation warning #97

Closed
designermonkey opened this issue Dec 19, 2021 · 4 comments
Closed

PHP Deprecation warning #97

designermonkey opened this issue Dec 19, 2021 · 4 comments

Comments

@designermonkey
Copy link 

PHP Deprecated:  Return type of Ds\Vector::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /Users/john/Projects/jorpo-co/concerto/concerto-api/vendor/php-ds/php-ds/src/Traits/GenericSequence.php on line 355

This is with the polyfill on PHP 8.1, I will check now with the extension.
@designermonkey
Copy link
Author

All is well with the extension, so it's just the polyfill.

@rodber
Copy link

rodber commented Jan 29, 2022

I can see that this was pushed long ago: https://github.com/php-ds/polyfill/blame/a0a08f391847de2db0959b483e882aa91c4a2b70/src/Traits/GenericSequence.php#L355

Any chance to push a new tag to make this change available?

@Bilge
Copy link

Bilge commented Mar 8, 2022

@rtheunissen could we please get a tag?

@rtheunissen
Copy link
Member

Tagged 1.4.1

@Bilge Bilge mentioned this issue Mar 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@designermonkey @Bilge @rtheunissen @rodber