Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades to PHP >= 7.2 + Migrates to GitHub actions #11

Merged
merged 3 commits into from
Jan 12, 2021
Merged

Upgrades to PHP >= 7.2 + Migrates to GitHub actions #11

merged 3 commits into from
Jan 12, 2021

Conversation

rodber
Copy link
Contributor

@rodber rodber commented Jan 10, 2021

Hey there,

This simply bumps PHP to be able to use it with PHP 8. I also migrated your stuff to GitHub actions.

Hope it helps.

@oscarotero
Copy link
Member

Hi.
Thanks for this contribution.
Could you change the workflow for something like we have in the Gettext repository? https://github.com/php-gettext/Gettext/blob/master/.github/workflows/test.yaml (Your proposal is fine, but only for consistency)

@rodber
Copy link
Contributor Author

rodber commented Jan 12, 2021

I just copied the workflow, glad to help.

@oscarotero oscarotero merged commit 37eb56d into php-gettext:master Jan 12, 2021
@oscarotero
Copy link
Member

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rodber @oscarotero