Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PHP < 7.4? #242

Open
Chris53897 opened this issue Jan 21, 2024 · 4 comments
Open

Drop support for PHP < 7.4? #242

Chris53897 opened this issue Jan 21, 2024 · 4 comments

Comments

@Chris53897
Copy link
Contributor

Combined usage for PHP 7.1, to 7.3 is at 4 Percent for Version 2.
https://packagist.org/packages/php-http/client-common/php-stats#2

@xabbuh
Copy link
Member

xabbuh commented Jan 22, 2024

Would dropping support enable other things? For example, could the code be simplified because some code that is only present because of the support for PHP 7.3 could be removed?

@dbu
Copy link
Contributor

dbu commented Jan 22, 2024

yeah not much value in supporting it anymore. on the other hand, i usually only drop old versions when they hinder anything. if we would move to 8.0 or 8.1, we could modernize the code. i don't think dropping 7.1-7.3 allows to modernize anything.

if you want to work on it, i suggest we move to 8.1 directly (people on legacy php can keep using the legacy versions of this library. it is pretty stable, so no big hassle to maintain). and modernize the code where we can with new language features and strict types where possible without BC breaks.

eventually we could do a new major version with BC breaks, to have strict typing everywhere.

@Chris53897
Copy link
Contributor Author

Sounds good. I will work on this. I will set PHP 8.1 as minimum in that case.

@dbu
Copy link
Contributor

dbu commented Jan 22, 2024

thanks a lot! and as we just saw in #239 the legacy support does become cumbersome.

please for now no BC breaks, so that we can have a 2.x version with the cleanups and symfony 7 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants