Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhpDoc: missing attribute 'stream_factory' #244

Closed
Chris53897 opened this issue Jan 23, 2024 · 2 comments
Closed

PhpDoc: missing attribute 'stream_factory' #244

Chris53897 opened this issue Jan 23, 2024 · 2 comments

Comments

@Chris53897
Copy link
Contributor

https://github.com/php-http/client-common/blob/2.x/src/Plugin/RedirectPlugin.php#L116

I guess the correct one is this. (or FQCN)
@param array{'preserve_header'?: bool|string[], 'use_default_for_multiple'?: bool, 'strict'?: bool, 'stream_factory'?:StreamFactoryInterface} $config

@dbu
Copy link
Contributor

dbu commented Jan 23, 2024

oh right. yes your suggestion looks right. i think the tools that understand array shapes also understand use, so the short name is better to keep it readable.

@dbu
Copy link
Contributor

dbu commented Jan 29, 2024

fixed in #245

@dbu dbu closed this as completed Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants