Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call tips - Tooltip data as call-tips #301

Closed
Gert-dev opened this issue Jul 14, 2017 · 3 comments
Closed

Call tips - Tooltip data as call-tips #301

Gert-dev opened this issue Jul 14, 2017 · 3 comments
Labels
enhancement
Milestone
3.2

Comments

@Gert-dev
Copy link
Owner

Originally posted by @johnbillion (https://github.com/php-integrator/atom-call-tips-legacy-php56/issues/11)

The tooltips package provides the information I want, and the call-tips package provides it at the time I want it, but there's no way to get the best of both worlds.

What I'd like to see is the full docblock data that's available in tooltips, but displayed as a call-tip when my cursor is inside the function's brackets.

It'd be great to see this as an option.

Comment 1 (Gert-dev)

I have to admit that I sometimes have the same feeling. I also vaguely recall some IDE (Visual Studio or perhaps Eclipse?) showing a minimal call tip by default and allowing you to press a shortcut afterwards (e.g. ctrl + space) to expand the call tip with more information.

I don't think providing the option to expand the call tip will harm anyone, so I could implement that as a base and then add a package setting to always expand by default.
@Gert-dev Gert-dev changed the title Call tips - Call tips - Tooltip data as call-tips Jul 14, 2017
@marksagal
Copy link

I miss tooltip also :( available in legacy version but can't install 2 instance of php-integrator. .. tsskk :( tool tip has dockblockr info unlike calltips. .

@rikosage
Copy link

rikosage commented Jul 22, 2017 •
edited
Loading

I have the same problem.

PHP 7.1.7-1+ubuntu16.04.1+deb.sury.org+1 (cli)

Gert-dev added a commit that referenced this issue Oct 19, 2017
@Gert-dev
Replace signature help with atom-ide-ui's version
b669f84 
This replaces our own implementation with the one from atom-ide-ui. Next
to having a consistent UI with other IDE packages and benefitting from
improvements made over there, they also offer several advantages over
our own implementation:

  - It is configured here to automatically trigger (!) when the
    paranthesis is typed. To add to that, it automatically remains open
    as long as the user continues typing and doesn't move outside the
    function call. This means it will never pop up automatically unless
    either typing a new function call or explicitly requesting it.
  - You can easily close it by pressing escape (#300) or moving outside
    of the function call, so it gets in the way much less often.
  - It also displays, next to the active parameter's documentation, the
    documentation of the function itself (mostly deals with #301).
  - It displays above the function call, so it doesn't overlap with
    autocompletion (#311)
  - You can drag them out of the way.
  - You can attach keyboard triggers to them.

Finally, this code is pretty much ready for use on our end, but there
are some minor issues I'd like to see ironed out in atom-ide-ui before
releasing this:

  - The API is currently still experimental
  - The styling is currently a bit barebones; the name of the active
    parameter is not displayed.
  - HTML in descriptions is being escaped (same issue as
    facebookarchive/atom-ide-ui#99)

References #300
References #301
References #311
@Gert-dev Gert-dev added this to the 3.2 milestone Jan 27, 2018
@Gert-dev
Copy link
Owner Author

Gert-dev commented Feb 1, 2018

Closing this as 3.2 has been released. Call tips now use atom-ide-ui's and display the summary of the function inside them as well.

@Gert-dev Gert-dev closed this as completed Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
3 participants
@marksagal @rikosage @Gert-dev