Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call tips hide firsts autocomplete suggestions #311

Closed
jatubio opened this issue Jul 17, 2017 · 7 comments
Closed

Call tips hide firsts autocomplete suggestions #311

jatubio opened this issue Jul 17, 2017 · 7 comments
Labels
Milestone

Comments

@jatubio
Copy link

jatubio commented Jul 17, 2017

I'm not sure if this is related with this enhancement proposal: #300, but i think on this more as one issue.

When i'am writing and i type one function, sometimes call tip hide the firsts autocomplete suggestions. One picture it's better that 1000 words ;)

image

Version 3.0.0 on Atom 1.19.0-beta4 x64

@jatubio jatubio changed the title Call tips hide first autocomplete suggestion Call tips hide firsts autocomplete suggestions Jul 17, 2017
@Gert-dev
Copy link
Owner

Agreed! It is related to #300 in some ways, but I'll leave it open as separate issue as it's different enough and more of a bug than an enhancement.

@Gert-dev Gert-dev added the bug label Jul 19, 2017
@jatubio
Copy link
Author

jatubio commented Aug 30, 2017

Hello.

It is often quite uncomfortable for the popup to hide the code I am typing.
It would be possible at least to implement the possibility of hiding the popup by pressing the 'Esc' key?

Thank you

Gert-dev added a commit that referenced this issue Oct 19, 2017
This replaces our own implementation with the one from atom-ide-ui. Next
to having a consistent UI with other IDE packages and benefitting from
improvements made over there, they also offer several advantages over
our own implementation:

  - It is configured here to automatically trigger (!) when the
    paranthesis is typed. To add to that, it automatically remains open
    as long as the user continues typing and doesn't move outside the
    function call. This means it will never pop up automatically unless
    either typing a new function call or explicitly requesting it.
  - You can easily close it by pressing escape (#300) or moving outside
    of the function call, so it gets in the way much less often.
  - It also displays, next to the active parameter's documentation, the
    documentation of the function itself (mostly deals with #301).
  - It displays above the function call, so it doesn't overlap with
    autocompletion (#311)
  - You can drag them out of the way.
  - You can attach keyboard triggers to them.

Finally, this code is pretty much ready for use on our end, but there
are some minor issues I'd like to see ironed out in atom-ide-ui before
releasing this:

  - The API is currently still experimental
  - The styling is currently a bit barebones; the name of the active
    parameter is not displayed.
  - HTML in descriptions is being escaped (same issue as
    facebookarchive/atom-ide-ui#99)

References #300
References #301
References #311
@ricpelo
Copy link

ricpelo commented Dec 22, 2017

I have the same issue. Is there a workaround? A temporary fix? Can I do anything in order to help? Thanks.

@ricpelo
Copy link

ricpelo commented Dec 22, 2017

Maybe is commit b669f84 a fix for the issue?

@ricpelo
Copy link

ricpelo commented Dec 22, 2017

Just for the record, a workaround I finally found is to edit Atom ~/.atom/styles.less file and add the following:

atom-text-editor .autocomplete-plus {
    z-index: 5 !important;
}

This way, autocompletion shows over signature help. It isn't perfect, but works.

@Gert-dev
Copy link
Owner

Gert-dev commented Dec 23, 2017

@ricpelo Yes, that commit would be the ideal fix. I can't merge this, however, until this issue in atom-ide-ui is solved.

If you want to roll up your sleeves and help, a patch for atom-ide-ui to make the sanitization optional would be the best course of action. I have no idea if they'd be willing to accept it, however, as it seems kind of silent over there.

@Gert-dev Gert-dev added this to the 3.2 milestone Jan 27, 2018
@Gert-dev
Copy link
Owner

Gert-dev commented Feb 1, 2018

Closing this as 3.2 has been released, which uses atom-ide-ui's tooltips. These show at another location by default so they usually don't obstruct autocompletion and can be moved out of the way with the mouse otherwise.

@Gert-dev Gert-dev closed this as completed Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants