Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexing PHP code message repeated multiple times #372

Closed
ricpelo opened this issue Feb 3, 2018 · 7 comments
Closed

Indexing PHP code message repeated multiple times #372

ricpelo opened this issue Feb 3, 2018 · 7 comments

Comments

@ricpelo
Copy link

ricpelo commented Feb 3, 2018

While indexing the project, if I keep going editing the file, message is repeated multiple times.

2018-02-03-213842_1280x985_scrot

@Nixes
Copy link

Nixes commented Feb 6, 2018

I'm also seeing this since the update to 3.2. Quite distracting.
image

Gert-dev added a commit that referenced this issue Feb 8, 2018
@Gert-dev
Copy link
Owner

Gert-dev commented Feb 8, 2018

Should be fixed in 3.2.1.

@ricpelo
Copy link
Author

ricpelo commented Feb 10, 2018

Sorry, I still can reproduce this issue with 3.2.1.
2018-02-10-103704_1280x985_scrot

@Gert-dev
Copy link
Owner

Gert-dev commented Feb 13, 2018

@ricpelo Ah, that isn't a bug in itself, but admittedly looks somewhat strange. This happens because your project is still indexing, and other index requests for files you are modifying in the meantime are queued to be performed afterwards, hence the messages stack up.

Internally, the base package is smart enough to cancel the first two when a third one arrives for the same file, but the (cancelled) response for that cancelled request isn't sent by the core until the original request is actually handled (i.e. after the project indexing finishes), at which point the core sees that the request is cancelled and sends the appropriate response. The base package then picks up that response, rejects the indexing promise, and the message finally disappears.

@ameenross
Copy link

ameenross commented May 9, 2018

I'm now having this problem with version 4.1.1
It appears that the indexing is never actually run. Just the queue is built. I also cannot force re-index; in this case not even a queue item is made.

Yesterday I removed the package and reinstalled it, the problem was solved. But it returned today.

@ameenross
Copy link

In fact, I probably also removed the core last time I reinstalled. I just went fixing it again, and it turns out that rm -rf ~/.cache/php-ide-serenata is required to fix it. Just removing the index DB file is not enough. When the core is gone, it will be re-downloaded and indexing starts from scratch. That works.

Then when I close and restart Atom, it breaks right away. Not just indexing, also click-through is broken.

@ameenross
Copy link

So while updating to 4.1.2 this morning I observed strange behaviour. I had it disabled, then I enabled it while it was updating. Then, to my surprise, it worked... so I did some more debugging.

It seems like a race condition (maybe more than one). I tried having the package disabled, start Atom, then enable it (like I did when I updated it). Broken. Then I tried the same thing, but without the option "continuous indexing" enabled. Works...

I just tried with a fresh ~/.atom, and it has the exact same problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants