Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: RuntimeException in constructor #51

Closed
SergioFloresG opened this issue Aug 17, 2018 · 1 comment
Closed

Request: RuntimeException in constructor #51

SergioFloresG opened this issue Aug 17, 2018 · 1 comment
Labels
accepting pull request

Comments

@SergioFloresG
Copy link

I have noticed that the constructor throws an ErrorException and the IDE always marks the warning that the Exception is not captured, so I propose to change it for RuntimeException since the dependency of the library is in execution time and not process.
@amouhzi
Copy link
Member

amouhzi commented Aug 18, 2018

Thank you for raising the problem. I will accept a pull request for that.

@evilangelmd evilangelmd mentioned this issue Dec 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepting pull request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SergioFloresG @amouhzi