Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php 8 support #322

Closed
hedii opened this issue Dec 19, 2020 · 8 comments
Closed

Php 8 support #322

hedii opened this issue Dec 19, 2020 · 8 comments

Comments

@hedii
Copy link

hedii commented Dec 19, 2020

Hi, it looks like the latest php release (8.0) is not supported.
Every dependency listed in composer.json has an available version compatible with php 8.0.
But the test suite may need some updates using a newer phpunit version.

@ChristophWurst
Copy link
Contributor

FYI it's all there in #325. From what I can tell the package will just work fine with php8.0 as is, but I'd still hope the maintainers have a moment to review that PR soon-ish :)

✌️

@haphan
Copy link
Collaborator

haphan commented Jan 22, 2021 via email

@ChristophWurst
Copy link
Contributor

No worries @haphan and sorry if I was too pushy.

@pcieszkowski
Copy link

Any progress on this? :)

@ChristophWurst
Copy link
Contributor

@pcieszkowski you may help test #325. From what I can tell this package works fine with php8 but having it double-checked won't hurt.

@pcieszkowski
Copy link

@ChristophWurst I'll give it a try later on

@pcieszkowski
Copy link

@ChristophWurst glad to tell that it works! smooth as butter :)

@hedii
Copy link
Author

hedii commented Apr 8, 2021

Fixed by release 3.2.0

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants