Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot API 6.3 #1370

Closed
29 tasks done
TiiFuchs opened this issue Nov 7, 2022 · 4 comments
Closed
29 tasks done

Bot API 6.3 #1370

TiiFuchs opened this issue Nov 7, 2022 · 4 comments
Assignees
Labels

Comments

@TiiFuchs
Copy link
Member

TiiFuchs commented Nov 7, 2022

  • Added support for Multiple Usernames via the field active_usernames in the class Chat.
  • Added the field emoji_status_custom_emoji_id to the class Chat.

Database Changes

  • Added the field is_forum to the class Chat.
  • Added the fields is_topic_message and message_thread_id to the class Message
  • Added the fields forum_topic_created, forum_topic_closed, and forum_topic_reopened to the class Message
@TiiFuchs
Copy link
Member Author

TiiFuchs commented Nov 7, 2022

@noplanman The chat table in the DB does not contain every field of the Chat class.
Is that intentional?

Plus it still has a all_members_are_administrators field...?
Don't know where this comes from... Changelog.md says it was removed from Message entity.

@TiiFuchs
Copy link
Member Author

TiiFuchs commented Nov 7, 2022

Now only the DB changes for Chat are left.

The question remains whether the new fields should be created and whether the missing fields should be retrofitted.

@TiiFuchs TiiFuchs self-assigned this Nov 7, 2022
@noplanman
Copy link
Member

@TiiFuchs Where is the PR?

The Chat table doesn't include columns for values that are "Returned only in getChat".
We save in the DB what comes through from the API in messages, it's not an active scraping of data, which would need to be done periodically to keep it updated.

The all_members_are_administrators field was left for BC in the last release, in case users were accessing it directly from the DB still. Let's leave it in for now and add a "Will be removed in the next release" note for the next changelog entry.

@TiiFuchs
Copy link
Member Author

TiiFuchs commented Nov 7, 2022

Work is in the api-6.3 branch. PR comes when it's finished.

@TiiFuchs TiiFuchs mentioned this issue Nov 7, 2022
@TiiFuchs TiiFuchs closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants