Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor static helper classes/methods to instances #95

Open
adri opened this issue Jan 24, 2015 · 0 comments
Open

Refactor static helper classes/methods to instances #95

adri opened this issue Jan 24, 2015 · 0 comments
Labels
Feature New feature or request

Comments

@adri
Copy link
Contributor

adri commented Jan 24, 2015

Refactor helper classes as they don't play nice with the open closed and dependency inversion principle and make mocking during tests hard/impossible.

  • CurlHelper and StreamHelper are Mappers (from curl options and stream context to Request objects)
  • Find out what to do with TextUtil and HttpUtil

Instances of the new classes can be injected in the VCRFactory.
@adri adri added Feature New feature or request refactoring labels Jan 24, 2015
@adri adri changed the title Refactor static helper classes to Refactor static helper classes/methods to instances Jan 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adri @carusogabriel