Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOMElement::setAttributeNode(NS) inconsistent return type #1400

Closed
AndrolGenhald opened this issue Feb 11, 2022 · 0 comments · Fixed by #2601
Closed

DOMElement::setAttributeNode(NS) inconsistent return type #1400

AndrolGenhald opened this issue Feb 11, 2022 · 0 comments · Fixed by #2601
Labels
bug Documentation contains incorrect information Extension: dom good first issue Good for newcomers

Comments

@AndrolGenhald
Copy link

https://www.php.net/manual/en/domelement.setattributenode.php
https://www.php.net/manual/en/domelement.setattributenodens.php

The descriptions return DOMAttr|null|false, but the Return Values section for setAttributeNode says it returns the old attribute or null, and for setAttributeNodeNS it just says "Returns the old node if the attribute has been replaced" with no mention of either null or false.
@Girgias Girgias added bug Documentation contains incorrect information good first issue Good for newcomers labels Sep 13, 2022
@nielsdos nielsdos mentioned this issue Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Documentation contains incorrect information Extension: dom good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Corrections and clarifications to setAttributeNode(NS) nielsdos/doc-en
2 participants
@AndrolGenhald @Girgias