New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated Spoofchecker docs don't include stubs restricted by define #2283

Closed

othercorey opened this issue Feb 9, 2023 · 1 comment

Contributor

othercorey commented Feb 9, 2023

The stub for Spoofchecker::setRestrictionLevel() exists but doesn't seem to be included in the docs.

#if U_ICU_VERSION_MAJOR_NUM >= 58
    /** @tentative-return-type */
    public function setRestrictionLevel(int $level): void {}
#endif

https://github.com/php/php-src/blob/master/ext/intl/spoofchecker/spoofchecker.stub.php#L96-L99

Do we need to manually add the file or are they generated by a script that needs to be udpated?

https://www.php.net/manual/en/class.spoofchecker

The text was updated successfully, but these errors were encountered:

othercorey mentioned this issue

Fix Spoofchecker callmaps vimeo/psalm#9256

Merged

Contributor Author

othercorey commented Feb 9, 2023 •

edited

Closing as I see a PR was opened for this surprisingly. #2274

othercorey closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment