MimeMessage::__construct() throws TypeError with $mode=stream

[akamah]

I have read this section of README.md and tried the following code:

<?php
$fp = fopen("tests/testdata/uue.txt", "r");
$msg = new MimeMessage("stream", $fp);
var_dump($msg);

But resulted in the following TypeError:

PHP Fatal error:  Uncaught TypeError: mimemessage::__construct(): supplied argument is not a valid stream resource in /Users/akm/repo/pecl-mail-mailparse/test.php:3
Stack trace:
#0 /Users/akm/repo/pecl-mail-mailparse/test.php(3): mimemessage->__construct()
#1 {main}
  thrown in /Users/akm/repo/pecl-mail-mailparse/test.php on line 3

I confirmed it works correctly when the mode is 'file':

<?php
$msg = new MimeMessage("file", "tests/testdata/uue.txt");
var_dump($msg);

Output:

class mimemessage#1 (2) {
  public $data =>
  array(11) {
    'headers' =>
...

I expect the MimeMessage object can be initialized correctly even if $mode is 'stream'.

Environment

• mailparse version: 3.1.4
• PHP Version: 8.1.13
• Operating System: macOS 12.5.1

[akamah]

I think we don't need the following line to convert the argument into string but I'm not sure.

pecl-mail-mailparse/mailparse.c

Line 284 in 7f58ef4

convert_to_string_ex(&part->source.zval);

[remicollet]

I think we don't need the following line to convert the argument into string but I'm not sure.

INdeed.

[remicollet]

Please test from git