Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compatibility with PHP 8.0.0RC1 #5

Closed
wants to merge 1 commit into from
Closed

fix compatibility with PHP 8.0.0RC1 #5

wants to merge 1 commit into from

Conversation

remicollet
Copy link
Contributor

  • add arginfo to all functions
  • clean TSRMLS-* macros usage

@remicollet
fix compatibility with PHP 8.0.0RC1
b9aec33 
- add arginfo to all functions
- clean TSRMLS-* macros usage
@remicollet
Copy link
Contributor Author

Notice: this is a minimal patch without type hinting.

@nono303
Copy link

nono303 commented Nov 6, 2020

Thanks @remicollet !
Your patch works fine for 8.0.0RC3 on Windows build

Base automatically changed from master to main January 14, 2021 15:01
@cmb69
Copy link
Contributor

cmb69 commented May 17, 2021

This appears to be obsoleted by 7e762e7.

@remicollet remicollet closed this May 17, 2021
@remicollet remicollet deleted the issue-php8rc1 branch May 17, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@remicollet @nono303 @cmb69