-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PHPDBG: fix bug parsing 3-word opcodes
PHPDBG won't parse opcodes correctly if they are more than two words separated by underscores (as many opcodes, like ZEND_POST_INC, are). Now opcodes that have more than one underscore (e.g. ZEND_POST_INC) are parsed correctly. Closes GH-6895.
- Loading branch information
Showing
2 changed files
with
42 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
--TEST-- | ||
Test parsing longer opcode | ||
--PHPDBG-- | ||
b ZEND_POST_INC | ||
r | ||
c | ||
|
||
|
||
|
||
q | ||
--EXPECTF-- | ||
[Successful compilation of %s] | ||
prompt> [Breakpoint #0 added at ZEND_POST_INC] | ||
prompt> [Breakpoint #0 in ZEND_POST_INC at %s:3, hits: 1] | ||
>00003: echo $i++; | ||
00004: echo $i++; | ||
00005: echo $i++; | ||
prompt> 1 | ||
[Breakpoint #0 in ZEND_POST_INC at %s:4, hits: 2] | ||
>00004: echo $i++; | ||
00005: echo $i++; | ||
00006: echo $i++; | ||
prompt> 2 | ||
[Breakpoint #0 in ZEND_POST_INC at %s:5, hits: 3] | ||
>00005: echo $i++; | ||
00006: echo $i++; | ||
00007: | ||
prompt> 3 | ||
[Breakpoint #0 in ZEND_POST_INC at %s:6, hits: 4] | ||
>00006: echo $i++; | ||
00007: | ||
prompt> 4 | ||
[Script ended normally] | ||
prompt> | ||
--FILE-- | ||
<?php | ||
$i = 1; | ||
echo $i++; | ||
echo $i++; | ||
echo $i++; | ||
echo $i++; |